Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register metrics defined at Resource level #920

Merged
merged 1 commit into from
Apr 2, 2016
Merged

Register metrics defined at Resource level #920

merged 1 commit into from
Apr 2, 2016

Conversation

patrox
Copy link
Contributor

@patrox patrox commented Feb 20, 2016

If a Resource class is annotated with either:

  • @Timed,
  • @Metered
  • @ExceptionMetered

all method defined in such class will 'inherit' the corresponding annotation.

@patrox
Register metrics defined at Resource level
a04c30d 
If a `Resource` class is annotated with either:

* `@Timed`,
* `@Metered`
* `@ExceptionMetered`

all method defined in such class will 'inherit'
the corresponding annotation.
@patrox patrox mentioned this pull request Feb 20, 2016
Closed
@patrox
Copy link
Contributor Author

patrox commented Feb 29, 2016

@ryantenney I was wondering if you could have a look at this PR and let me know if you have any comments (positive or negative) ?

@ryantenney
Copy link
Contributor

I certainly will, but I'm very busy right now, I'll get to it soon.

@patrox
Copy link
Contributor Author

patrox commented Mar 30, 2016

@ryantenney Just reminding you about this PR, would really love to get some feedback from you,
so we don't need to keep a separate fork with the change.

@ryantenney ryantenney merged commit 1769cf5 into dropwizard:master Apr 2, 2016
@ryantenney
Copy link
Contributor

@patrox Thank you, and I'm so sorry for the delay getting this merged.

@patrox
Copy link
Contributor Author

patrox commented Mar 13, 2017 •
edited
Loading

Hi @ryantenney @arteam,
I'm wondering, if the changes from this PR were released as part of some of the latest releases ?

Cause I checked, and I couldn't find them :( Can you please check ?

@jplock
Copy link
Member

jplock commented Mar 13, 2017

@patrox this went into master and I don't think was cherry-picked into the 3.1 or 3.2 release branches, so we'd have to wait until 4.0 for this one.

@jplock jplock added this to the 4.0.0 milestone Mar 13, 2017
@arteam
Copy link
Member

arteam commented Mar 13, 2017

I will take a look. I moved a bunch of merge requests manually from the 4.0 branch to 3.2, maybe I missed this.

@patrox
Copy link
Contributor Author

patrox commented Mar 14, 2017 •
edited
Loading

thanks @jplock & @arteam, I appreciate your prompt responses

@arteam arteam mentioned this pull request Mar 14, 2017
Merged
@arteam arteam modified the milestones: 4.0.0, 3.2.0 Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@patrox @ryantenney @jplock @arteam