-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If provided by user, add config file to titlebar. #738
Conversation
Working fine in main but not showing in reporter. |
Sorry, I missed the part in the original issue about FreeDV Reporter. I'm not sure about doing this there, too, since that would make the version string significantly longer. Could this be something that can be done manually via the existing Message field? |
I don't understand, I am only talking about the reporter window decoration (window heading or title bar whatever it is called) not the version string used in the table. The reporter title bar does not currently show the freedv version string, only "FreeDV Reporter" I am suggesting that it shows "FreeDV Reporter (configfilename)". |
In latest KDE Plasma6 there are separate task bar items for 'FreeDV' and 'FreeDV Reporter' rather than the Plasma5 method that shows FreeDV+ on a single taskbar item when there is more than one window open belonging to FreeDV. When using multiple desktops it is still possible to inadvertently click a task bar item belonging to a different desktop such that you are seeing instance 1 of FreeDV and instance 2 of Reporter. Hence my request to have a simple indication of which is which in the title bars of both. In use I have found the addition of the config filename really useful to see at a glance which is on screen. I don't think trying to change 'icons' is the way to go. Can the config filename be added to the reporter window title bar string as in the main window, or is there technical reason that does not allow this? |
Noted. It's probably still a good idea to make the Linux behavior match Windows and macOS, though; showing the gear icon (with GNOME for example) isn't ideal no matter how many instances of FreeDV you're running. This can be done as a separate PR for sure. EDIT: #740 created for whenever I or someone else gets around to it.
AFAIK I don't think there's a technical reason, just figuring out if there's a better solution that will help achieve what you're looking for (ensuring you don't accidentally pull up the wrong window(s)). |
FWIW if you use a Fedora package (either distro or self built) then the FreeDV icon will show up under GNOME, not sure about KDE as I rarely change DE. |
I'm not 100% convinced, but it's an easy enough change so I went ahead and added it to the FreeDV Reporter window. We can always back it out if it ends up not working out. Let me know how the latest commit in this PR goes. |
Thanks! This is now OK for me and makes it easy to check which instance is which. |
Any possibility of having multiple levels of folders for configs (similar to the voice keyer files from the previous PR)? Might still be a good idea to keep the folder names displayed too. There's also already some shortening of the name by using ~ instead of the full
I took a look and it seems that the remaining ones would be pretty much just setup type dialogs (e.g. Tools->Audio Options). Any use case where you'd be changing settings in more than one copy of FreeDV at a time? |
Sorry I don't understand the question. User config files can already be anywhere as any full path can be passed with the -f option.
Why is it useful to show any of the path in the titlebar when the user already MUST know where his config file is as he already passed it as a parameter on startup!
It's quite possible that since we cannot simply switch to RX only or stop reporting without stopping the modems and opening config files, that yes, we may be editing multiple config files at the same time. If I were to use e.g "TS450S" as a config filename and put it in ~/ then OK it would keep the titlebar quite clean however my config files would be scattered around my user home folder depending on the filename. - Messy! I see this as very similar to the way other softwares work e.g. dolphin file manager adds the remote machine hostname or IP to the titlebar when working on a remote machine. Or klog logging program which adds the log name that it is using to the titlebar. |
Good point. I shortened it to only show the filename. Still leaves the scenario where you have the same-named files in e.g.
But this is probably pretty unlikely.
shrug I added the name to all the other windows. We can revisit if that ends up becoming a problem. |
Looks fine to me, I reckon it can be merged into master. |
Resolves #737 by adding the path of a custom config file to the title bar. For example, if FreeDV is started via the following:
the titlebar could look something like this: