Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capacitor grounds not connected #27

Closed
eltobu opened this issue Apr 23, 2021 · 5 comments · Fixed by #28
Closed

Capacitor grounds not connected #27

eltobu opened this issue Apr 23, 2021 · 5 comments · Fixed by #28

Comments

@eltobu
Copy link
Contributor

eltobu commented Apr 23, 2021

As can be seen in the screenshots below, the grounds of the two capacitors are connected to each other and a ground fill island on the bottom side.
This ground fill island is then not connected to the rest of ground, but it should be.
Top side:
image
Bottom side:
image
@eltobu eltobu mentioned this issue Apr 23, 2021
Merged
@blurfl
Copy link
Contributor

blurfl commented Apr 23, 2021

That's a good find. Could you add pics to PR #28 to show the fix?

@eltobu
Copy link
Contributor Author

eltobu commented Apr 23, 2021

Yeah, would have been a good idea in the first place.
I have added screenshots of the full board and both layers.

blurfl added a commit to blurfl/infidel-sensor that referenced this issue Apr 23, 2021
@blurfl
change EAGLE files to capture PR drspangle#28 and Issue drspangle#27
53b9296 
change EAGLE files to capture PR drspangle#28 and Issue drspangle#27

Update GERBER files as well as EAGLE files
@blurfl blurfl mentioned this issue Apr 23, 2021
Merged
drspangle added a commit that referenced this issue Apr 23, 2021
@drspangle
Merge pull request #29 from blurfl/fix-capacitor-grounds-not-connecte…
288c95d 
…d-EAGLE-SMD

change EAGLE files to capture PR #28 and Issue #27
@darigovresearch
Copy link
Collaborator

@eltobu good catch, & @blurfl thanks for the fix. Can anyone tell if this issue is also in the KiCad version of the project as it was autogenerated a week before this fix?

@drspangle
Copy link
Owner

@darigovresearch As far as I can tell, #28 addressed the problem in the KiCad version, and #29 addressed the problem in the EAGLE version.

@darigovresearch
Copy link
Collaborator

Thanks @drspangle for confirming & @blurfl for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix capacitor grounds not connected eltobu/infidel-sensor
4 participants
@blurfl @drspangle @eltobu @darigovresearch