Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f show will crash the client if there are too many users or factions in the message #44

Closed
fuzzybot opened this issue Aug 18, 2014 · 2 comments
Closed

f show will crash the client if there are too many users or factions in the message #44

fuzzybot opened this issue Aug 18, 2014 · 2 comments

Comments

@fuzzybot
Copy link

I made a quick hack to fix this on our server: https://gist.github.com/mccore/ce96721c87d3ab033b18

A more permanent solution should be created (or ideally, use real json chat for everything).
@drtshock
Copy link
Owner

Can you PR this?

drtshock added a commit that referenced this issue Aug 26, 2014
@drtshock
Limit length of f show messages. Fixes issue #44.
2fab9d3 
Clients could crash if the messages were too long so we'll limit it here. Thanks to @mccore for the method here.
drtshock added a commit that referenced this issue Aug 26, 2014
@drtshock
Limit length of f show messages. Fixes issue #44.
0f88e85 
Clients could crash if the messages were too long so we'll limit it here. Thanks to @mccore for the method here.
@drtshock
Copy link
Owner

Ok. First commit messed up a bit but now I got it ;D Thanks

0f88e85

@cuddylier cuddylier mentioned this issue Aug 28, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drtshock @fuzzybot