Refactor project. New tests. Add key import/removal and raw functions. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drudge Hope you have a chance to merge this. |
|
@freewil any thoughts on this? |
|
sorry I haven't had time to review this, will do so this weekend |
| buffersLength += buf.length; | ||
| fs.readFile(fileName, function(readErr, str) { | ||
| if (readErr) return fn(readErr); | ||
| GPG.importKey(str, args, fn); |
There was a problem hiding this comment.
I think for consistency with the rest of the file this should be self.importKey
|
This looks great, just fix that one little issue and I'll merge it! 🎉 |
freewil
added a commit
that referenced
this pull request
Oct 11, 2015
Refactor project. New tests. Add key import/removal and raw functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more or less a rework of the project structure to streamline it and easily allow for the addition of new functions.
New functions added:
Also added generic functions
call()andcallStreaming()so users can easily call gpg with any params they wish.