Raw values ready for review. #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FieldItemDeriver.
…hich we don't support here anyways.
pmelab
reviewed
Aug 2, 2017
| * @GraphQLField( | ||
| * id = "raw_field", | ||
| * nullable = true, | ||
| * weight = -1, |
There was a problem hiding this comment.
You have to set the weight higher than the one in RenderedField. I actually suggest lowering Rendered field to -10.
There was a problem hiding this comment.
I'm sorry, thats wrong. You can just remove the weight, then it will default to 0 which is fine for formatter based fields.
There was a problem hiding this comment.
The line has been removed. Thanks for review!
There was a problem hiding this comment.
... and that made the tests green. Strangely, I wasn't able to reproduce the failure locally so it was really puzzling. You rock! 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #87. This is a rewrite of PR #133 with
DisplayedFieldchanges reverted. All derivers are now based onFieldFormatterDeriver.