-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw values ready for review. #223
Raw values ready for review. #223
Conversation
…FieldItemDeriver.
…hich we don't support here anyways.
* @GraphQLField( | ||
* id = "raw_field", | ||
* nullable = true, | ||
* weight = -1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to set the weight higher than the one in RenderedField
. I actually suggest lowering Rendered field to -10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, thats wrong. You can just remove the weight, then it will default to 0 which is fine for formatter based fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line has been removed. Thanks for review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and that made the tests green. Strangely, I wasn't able to reproduce the failure locally so it was really puzzling. You rock! 🥇
Issue #87. This is a rewrite of PR #133 with
DisplayedField
changes reverted. All derivers are now based onFieldFormatterDeriver
.