This repository has been archived by the owner on Jan 5, 2018. It is now read-only.
URL Embed Button config entity #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md add url embed filter intial Delete UrlEmbedFilter.php~ add url_info.yml Update url_embed.info.yml change_directory_structure remove duplicated directory remove duplicate file URLEmbedFilter correct class name remove unnecessary functions remove unnecessary imports remove unnecessary imports inital text_filter Intial Code for Url Button track url button files update UrlButton.php update url button remove sourceMachineName from interface update UrlButtonListBuilder initial commit For Forms remove entity-bundle related functions change Filenames update UrlEmbedDialog.php rename URL to Entity add routing.yml Add yml files update UrlButton.php Debug Url Button Forms Remove Entity Type from URLButtonlistBuilder Create UrlButtonCrudTest Update UrlButtonCrudTest update urlButton create UrlButtonAdmin Tests Update UrlButtonCrudTest untrack Embed Dialog Form remove Embed Library Add Travis CI configuration Try using drupal_ti script with sudo: required Try manually downloading, enabling and running composer manager Remove code Support composer-manager. Remove debug option Only test 8.x-1.x commits (plus pull requests) Re-add composer_manager dependency Removed duplicated notifications key Update to drupal_ti 1.3.0, support sudo:false, sync with dist file. Do not allow PHP 7 failures update UrlButton.php checkout UrlEmbedFilter for process text add links.yml update urlbutton and listbuilder update CRUD Test add yml files Edit Schema Debug Url_Buttons Remove Source, Provider and Display Plugin from button and forms merge label and button_label Correct coding standards remove Oembed variable from Url Button replce Url with URL wherever necessary
prateekmehta
force-pushed
the
Url_Embed_Button
branch
from
ce5e10c
to
2c7fcd6
Compare
| */ | ||
| public function process($text, $langcode) { | ||
| $result = new FilterProcessResult($text); | ||
| try{ |
There was a problem hiding this comment.
try-catch should be inside the foreach loop so that even if one of the embed fails, rest still work.
| 'file_validate_image_resolution' => array('16x16'), | ||
| ), | ||
| ); | ||
| /* |
There was a problem hiding this comment.
Remove this kind of stuff instead of commenting it out. No stray comments.
| return $image->url(); | ||
| } | ||
| else { | ||
| return file_create_url(drupal_get_path('module', 'url_embed') . '/js/plugins/drupalurl/entity.png'); |
There was a problem hiding this comment.
Should we file this as a follow-up that we shouldn't be re-using the Entity Embed image but should be using something different?
There was a problem hiding this comment.
I couldn't find any other image. we can change it afterwards.
davereid
added a commit
that referenced
this pull request
Aug 5, 2015
URL Embed Button config entity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Url Button and Tests.