Issue #3045349 by alexpott, mikelutz, geerlingguy, catch, mglaman, la…

…rowlan: Lazy started sessions with session data are not saved with symfony/http-foundation 3.4.24

core/composer.json

@@ -22,7 +22,7 @@
         "symfony/console": "~3.4.0",
         "symfony/dependency-injection": "~3.4.26",
         "symfony/event-dispatcher": "~3.4.0",
-        "symfony/http-foundation": "~3.4.26",
+        "symfony/http-foundation": "~3.4.27",
         "symfony/http-kernel": "~3.4.14",
         "symfony/routing": "~3.4.0",
         "symfony/serializer": "~3.4.0",

core/lib/Drupal/Core/Session/SessionManager.php

@@ -216,9 +216,7 @@ public function regenerate($destroy = FALSE, $lifetime = NULL) {
       throw new \InvalidArgumentException('The optional parameters $destroy and $lifetime of SessionManager::regenerate() are not supported currently');
     }
 
-    // Only migrate the session if the session is really started and not only
-    // lazy started.
-    if ($this->started) {
+    if ($this->isStarted()) {
       $old_session_id = $this->getId();
       // Save and close the old session. Call the parent method to avoid issue
       // with session destruction due to the session being considered obsolete.
@@ -342,19 +340,4 @@ protected function migrateStoredSession($old_session_id) {
       ->execute();
   }
 
-  /**
-   * Checks if the session is started.
-   *
-   * Beginning with symfony/http-foundation 3.4.24, the session will no longer
-   * save unless this method returns true. The parent method returns true if
-   * $this->started is true, but we need the session to also save if we lazy
-   * started, so we override isStarted() here.
-   *
-   * @return bool
-   *   True if started, false otherwise
-   */
-  public function isStarted() {
-    return parent::isStarted() || $this->startedLazy;
-  }
-
 }