Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop looking in Drush folder for site aliases, config, and scripts #1748

Closed
weitzman opened this issue Nov 5, 2015 · 6 comments
Closed

Stop looking in Drush folder for site aliases, config, and scripts #1748

weitzman opened this issue Nov 5, 2015 · 6 comments
Milestone
drush9

Comments

@weitzman
Copy link
Member

weitzman commented Nov 5, 2015

We do useless scans into Drush itself for aliases and config. Lets remote the ability to put files there for Drush9. It wont easily work with a .phar anyway.
@greg-1-anderson
Copy link
Member

I sometimes see folks customizing their Drush installs by putting stuff here, and it makes me cringe. We don't use this facility ourselves, and any use of this feature is abusive. I agree we should take it out.

@jhedstrom jhedstrom added this to the drush8 milestone Nov 9, 2015
@jhedstrom
Copy link
Member

Is it too late for Drush 8?

@greg-1-anderson
Copy link
Member

I second the vote for taking this out in D8.

@weitzman
Copy link
Member Author

weitzman commented Nov 9, 2015

Personally, I think there isn't a need to surprise folks at the last minute on this. Do you have any specific reason to need this?

@greg-1-anderson
Copy link
Member

Nope. It can wait for D9 as far as I am concerned. It's just the wrong place to put custom stuff philosophically. You are probably right that this change might surprise some or make them not upgrade to D8, so I guess I don't care that much.

@jhedstrom jhedstrom removed this from the drush8 milestone Nov 10, 2015
@weitzman
Copy link
Member Author

Also stop searching inside Drush for scripts.

@weitzman weitzman added this to the drush9 milestone Jan 7, 2016
@weitzman weitzman changed the title Stop looking in Drush folder for aliases and config Stop looking in Drush folder for site aliases, config, and scripts Mar 17, 2016
weitzman added a commit that referenced this issue Mar 17, 2016
@weitzman
Merge pull request #2074 from drush-ops/1748-stop-searching-inside-dr…
42cc8dd 
…ush-dirs

Fix #1748. Stop looking in Drush folder for site aliases, config, scripts
@weitzman weitzman mentioned this issue Mar 17, 2016
Closed
mikeker pushed a commit to mikeker/drush that referenced this issue Aug 10, 2017
@weitzman @mikeker
Fix drush-ops#1748. Stop looking in Drush folder for site aliases, co…
26ef061 
…nfig, and scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
drush9
Development

No branches or pull requests
3 participants
@weitzman @jhedstrom @greg-1-anderson