Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drush migrate:fields-source vs. strict_types #6012

Closed
nevergone opened this issue May 27, 2024 · 3 comments
Closed

drush migrate:fields-source vs. strict_types #6012

nevergone opened this issue May 27, 2024 · 3 comments
Assignees

Comments

@nevergone
Copy link
Contributor

Describe the bug
Drupal migration source plugins return translated text (TranslatableMarkup) in field descriptions. See: https://api.drupal.org/api/drupal/core%21modules%21user%21src%21Plugin%21migrate%21source%21d7%21User.php/function/User%3A%3Afields/10
The strip_tags() PHP function given string in \Drush\Commands\core\MigrateRunnerCommands::fieldsSource() method.

Automatic type conversion cannot be used because of declare(strict_types=1);

To Reproduce
Load old Drupal-dump (for ex. Drupal7) and probe drush mfs d7_user command.

System Configuration

Q A
Drush version? 12.x/13.x
Drupal version? 10.x/
PHP version 8.x/
OS? Linux

Additional information
Please cherry-pick for 12.x branch.

@claudiu-cristea
Copy link
Member

@nevergone we need a PR

@nevergone
Copy link
Contributor Author

#6015

nevergone added a commit to nevergone/drush that referenced this issue May 28, 2024
claudiu-cristea pushed a commit that referenced this issue May 28, 2024
@nevergone
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants