Port docs- commands to Annotated #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jibran
reviewed
Aug 17, 2018
| 'callback' => 'drush_print_file', | ||
| 'callback arguments' => array($docs_dir . '/examples/example.aliases.drushrc.php'), | ||
| ); | ||
| $items['docs-ini-files'] = array( |
There was a problem hiding this comment.
I saw that we removed the example file but \Drush\Commands\core\EditCommands::phpIniFiles still supports DRUSH_INI, /etc/drush.ini and ~/.drush/drush.ini.
Should we add example.drush.ini back?
There was a problem hiding this comment.
no, those files are no longer used. we need to fix EditCommands.
There was a problem hiding this comment.
See 2nd tip at http://docs.drush.org/en/master/install/
There was a problem hiding this comment.
So how are we going to update drush specific php config? Can we add php ini override in drush.yml?
There was a problem hiding this comment.
What is your use-case for drush-specific php config?
There was a problem hiding this comment.
To setup the memory limit memory_limit = 256M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.