Issue #4935: Replace webmozart/path-util with symfony/filesystem

[ossobuffo]

symfony/filesystem as of v5.4 is pretty much a drop-in replacement for webmozart/path-util, at least for all the drush use-cases.

[weitzman]

Thanks for getting this going. Looks like consolidation/site-alias has a hidden dependency on webmozart. Lets fix that too. We can get that merged and released quickly.

Also note that you may see one security related test failure in drush thats unrelated to this PR.

[ossobuffo]

@weitzman See consolidation/site-alias#55

[effulgentsia]

This broke compatibility with both the Drupal 9 and Drupal 10 versions of drupal/core-dev, because the former requires symfony/filesystem: ^4.4 and the latter requires symfony/filesystem: ^6.1. See also drupal/core-dev#3.

[ossobuffo]

I would imagine we could fix this by changing drush's composer.json filesystem reference to this:

"symfony/filesystem": "^4.4 || ^5.4 || ^6.1",

but this would require more testing.

[weitzman]

Ouch. That approach won’t work for 4 because path functionality is not in file system v4. Looks like we gotta revert this.

[Pasqualle]

It would be nice to allow symfony/filesystem version 6.

Can we just remove symfony/filesystem dependency for drush, as it is already required by consolidation/site-alias (by both consolidation/site-alias versions: ^3.1.6 and ^4).

$ composer why symfony/filesystem
chi-teck/drupal-code-generator 2.6.1    requires symfony/filesystem (^4.4 || ^5.1 || ^6)
consolidation/robo             3.0.10   requires symfony/filesystem (^4.4.9 || ^5 || ^6)
consolidation/self-update      2.0.5    requires symfony/filesystem (^2.5 || ^3 || ^4 || ^5 || ^6)
consolidation/site-alias       4.0.0    requires symfony/filesystem (^5.4 || ^6)
drush/drush                    11.x-dev requires symfony/filesystem (^4.4 || ^5.4)

$ composer why consolidation/site-alias
consolidation/site-process 5.1.1    requires consolidation/site-alias (^3 || ^4)
drush/drush                11.x-dev requires consolidation/site-alias (^3.1.6 || ^4)

https://packagist.org/packages/consolidation/site-alias#3.1.6
https://packagist.org/packages/consolidation/site-alias#4.0.0

[weitzman]

It doesn’t make sense to me to to remove the dependency. We use it extensively. Happy to expand its constraint.

[Pasqualle]

note: symfony/filesystem ^6.1 added in #5292