-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webmozart/path-util is abandoned #4935
Comments
Oy. We use that everywhere! |
Sad panda. It's a small library; I guess we could just copy it into Drush, or maybe fork it into Consolidation and adopt ownership. We could review symfony/filesystem and see if it really does contain all of the methods in path-util; last time I checked, it didn't, but that was a while ago. |
Any way to contact them? |
I found this at their support page https://symfony.com/support https://github.com/symfony/symfony/discussions I posted there: |
We faced this problem in typhonius/acquia-php-sdk-v2#219 and found it easy enough to migrate to symfony/filesystem, all of the functions were the same. The only problem is that it breaks compatibility with Symfony 4. Incompatibility with Symfony 4 is the biggest problem here and looks like it would affect Drush as well. I think Symfony should backport this to Symfony 4 since it's supposed to be supported for a few years yet. |
I opened an upstream feature request with Symfony to backport Path functionality to Symfony 4: symfony/symfony#44897 |
Thanks @danepowell |
FYI from Symfony's point of view, the legacy code should be copied back into projects that need it since they will not add it as a new feature back into v4--and they closed the above ticket on it symfony/symfony#44897 (comment) |
Sounds like we keep depending on the abandoned package until someone submits a PR to change our calls. |
Copying the code into individual projects is half of a solution: it at least gets rid of the end-user warning, and mitigates the risk of something bad or malicious happening to the abandoned package. It doesn't help much with maintenance though. I might fork path-util with the sole purpose of porting future changes (if any) from Symfony. Then projects like Drush can rely on the half-maintained fork. Ideally Symfony would maintain this themselves, but judging by the tepid reaction to symfony/symfony#44897, that seems unlikely. |
* Issue #4935: Replace webmozart/path-util with symfony/filesystem * Add drush.php to list of files whose use statements change * Ensure that Path::join() receives strings instead of array Co-authored-by: Daniel Johnson <djohnson@webfirst.com>
Fixed in #5264 |
Describe the bug
Installing Drush via Composer produces a warning:
I know this is just a warning and end users can ignore it for now, but it's still a risk (bad things happen to abandoned packages) and the package needs to be removed/replaced.
To Reproduce
composer require drush/drush
Expected behavior
No warnings
Actual behavior
Workaround
Ignore the warning
System Configuration
The text was updated successfully, but these errors were encountered: