/dev/stdout Compatibility Fixes (Termux, et. al.) #1276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/dev/stdout may not be accessible. .
|
Hi Daniel, quick shot: please use double brackets only. And at the right hand side inside those brackets your normally don;t need to put in quotes, unless there is something to quote. Dirk |
|
Whoops! Okay! Sorry -- let me fix. |
|
No prob, just a matter of programming style. Take your time. I am just shutting everything down for the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR per #1273 -- not sure if this is the best way to accomplish this but I have tested it on the latest Termux and it does work. Additionally, perhaps the zlib testing (line ~14020) could be done in a better way? (It seems strange to test for zlib if $SSL_NATIVE is off? At a quick glance, it seems maybe that if $SSL_NATIVE is off, it's not even necessary to test whether openssl supports zlib? Please check me on this.)
.