Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Tokens" to "Tiles / Tokens", allow them to be placed in player's hands. #252

Open
GrimPixel opened this issue Mar 9, 2023 · 5 comments
Labels
assets Related to assets or asset packs tweak Tweak an existing feature ui Related to the UI
Milestone

Comments

@GrimPixel
Copy link

GrimPixel commented Mar 9, 2023

Is your feature request related to a problem? Please describe.
Tiles are cuboid tokens in shape and cards in essence. Due to practical reasons in real life, they are much thicker than cards.

Describe the solution you'd like
Now that cards are already defined in Vector2, and tokens can't be placed in hands, the solution is to have the new category for them.

I have noticed that pieces are now lifted straight vertically. This could apply to tiles as well, as they can be placed next to each other tightly.

Describe alternatives you've considered
Treat tiles as tokens and add the ability of having tokens in hand. The problem is, it adds up the difficulty of finding tokens in Mahjong,. In addition, tokens may be placed in hand in Poker accidentally.

@drwhut
Copy link
Owner

drwhut commented Mar 9, 2023

I see, it does make sense to have an object that both can be put in the player's hand, and can have it's height configured.

I have an alternate solution to consider: what if instead of an entirely different type of object, there was a configurable property for both cards and tokens called something like can_hold or can_put_in_hand, which if set to true would allow it to be put in the player's hand? That way, it could be set to false for things like poker chips to avoid the situation you mentioned.

What are your thoughts on this?

@drwhut drwhut added the feature New feature or request label Mar 9, 2023
@GrimPixel
Copy link
Author

Regarding to the name, which indicates the usage of something, they are different from “tokens”. New players will find it strange for their first impression. It feels like being placed somewhere belonging to other stuffs, like a cohesion between two modules.

@drwhut
Copy link
Owner

drwhut commented Mar 9, 2023

My thinking is that, between "Tiles" and "Tokens", the only functional difference is that one can be placed in a player's hand, and the other can't. Having "Cards" be a category of it's own makes sense I think, but the problem with "Tiles", "Tokens", etc. is that the names are generic by design to account for any number of games. That's why I suggested the alternative to make it a configurable property, since a. the type names are generic anyways, and b. I'm not 100% sure if one functional difference is enough for it to warrant an entirely new directory in an asset pack.

@GrimPixel
Copy link
Author

Hmm, then "Tokens" could be renamed to include both. When tile games come in, real tokens will be marginal in number.

@drwhut drwhut changed the title Add category “Tiles” Rename "Tokens" to "Tiles / Tokens", allow them to be placed in player's hands. Mar 15, 2023
@drwhut drwhut added this to the v0.2.0 milestone Mar 15, 2023
@drwhut drwhut added ui Related to the UI assets Related to assets or asset packs tweak Tweak an existing feature and removed feature New feature or request labels Mar 26, 2023
@drwhut
Copy link
Owner

drwhut commented Apr 25, 2023

I've been thinking about the UX when it comes to tile-based games in v0.2.0 (since in v0.1.0 it's not that intuitive, especially with dominoes where players need to set up their own hidden areas and flip the tiles as they come out of the container), and considering how containers are to tiles what stacks are to cards and tokens, when this issue is implemented I think it also makes sense to add options like "Deal X objects" or "Deal X tiles" to the context menu of containers.

drwhut added a commit that referenced this issue Sep 10, 2024
Now there's these cool things called folders! It's a totally new
invention, I think it'll do really well with those tiktok kids.

The way in which assets are displayed can also be adjusted now, with
both the button type and scale being variable.

This is primarily to fix #268, as the 3D previews were causing
random crashes in v0.1.x when going through the pages.

This also fixes #299, as tooltips now only show descriptions. I plan
to add a right-click option to show the full details of an asset.

This commit also contributes to #252, since tokens are now shown in
the UI as "Tiles / Tokens". The ability for tokens to be placed in
player's hands has not been implemented yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Related to assets or asset packs tweak Tweak an existing feature ui Related to the UI
Projects
None yet
Development

No branches or pull requests

2 participants