feat: parameters is optional when every parameter is optional #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 77c171b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
duncanbeevers
force-pushed
the
feat/optional-parameters-1334
branch
from
7103120
to
9aca5b1
Compare
Merged
1 task
3 tasks
drwpow
added a commit
that referenced
this pull request
Sep 25, 2023
3 tasks
drwpow
added a commit
that referenced
this pull request
Sep 25, 2023
drwpow
added a commit
that referenced
this pull request
Sep 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1334
Changes
Makes
parameterstype optionalparameters?: {when every parameter is optional.#1334
How to Review
parameters: {parameters?: {I haven't tested this beyond the single
optionalParamSchemaalready present in the test corpus.Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)