Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dry::Core::Inflector #8

Merged
merged 3 commits into from
Oct 1, 2016
Merged

Add Dry::Core::Inflector #8

merged 3 commits into from
Oct 1, 2016

Conversation

flash-gordon
Copy link
Member

No description provided.

@timriley
Copy link
Member

So I know this is an exercise in pulling stuff out of rom-support, but I wonder why we would want this here in dry-core instead of just having our things use Inflecto directly?

@solnic
Copy link
Member

solnic commented Sep 30, 2016

It's needed because folks who use rails or anything that have AS::Inflector will be able to use their setup. This way they won't have to install inflecto and their potentially customized inflection configuration will be respected.

@flash-gordon
Copy link
Member Author

Yeah, it looks a little bit odd to have something about inflections in something named core, but again this is a dummy wrapper which is ofc not required by default, and which allows you to not depend on inflecto in case you already have your own shiny AS. Having two infection engines at the runtime is not a great idea fwiw

@flash-gordon
Copy link
Member Author

btw, I started to ignore rbx fails, something is not quite right with it, I'll have a through look at this in a week or sutin
FYI current rvm-rbx status can be seen at https://travis-ci.org/rubinius/travis-canary

@solnic solnic merged commit bbbd510 into master Oct 1, 2016
@solnic solnic deleted the add-inflector branch October 1, 2016 15:41
@solnic
Copy link
Member

solnic commented Oct 1, 2016

Merged. This will be useful in many places so I'm actually not worried that this is added to core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants