Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate eql? in favor of is_eql? #98

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Deprecate eql? in favor of is_eql? #98

merged 1 commit into from
Oct 10, 2022

Conversation

solnic
Copy link
Member

@solnic solnic commented Oct 9, 2022

Refs #92

This was referenced Oct 9, 2022
Closed
Closed
flash-gordon
flash-gordon approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@flash-gordon flash-gordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

timriley
timriley requested changes Oct 10, 2022
View reviewed changes
Copy link
Member

@timriley timriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the deprecate line might need tweaking; see my inline comment.

@solnic solnic requested a review from timriley October 10, 2022 19:10
timriley
timriley approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@timriley timriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto 🍝

@solnic solnic merged commit 796c4f4 into main Oct 10, 2022
@solnic solnic deleted the 92-deprecate-eql-predicate branch October 10, 2022 19:12
solnic added a commit that referenced this pull request Oct 15, 2022
@solnic
Revert "Merge pull request #98 from dry-rb/92-deprecate-eql-predicate"
075a180 
This reverts commit 796c4f4, reversing
changes made to 894d0fb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timriley timriley timriley approved these changes

@flash-gordon flash-gordon flash-gordon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@solnic @timriley @flash-gordon