New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Unit as a default argument for Success(), Failure(), Some() #71

Merged

flash-gordon merged 1 commit into master from feature/default-unit

Oct 7, 2018

Member

flash-gordon commented Oct 6, 2018

I think it's a nice way to avoid things like Success(nil). We already had Unit but the ergonomics wasn't ideal.

include Dry::Monads::Result::Mixin
include Dry::Monads::Do

def call
  yield do_1
  yield do_2

  Success()
end


          Use Unit as default argument for Success(), Failure(), Some()

63de67d

I think it's a nice way to avoid things like `Success(nil)`

Member

timriley commented Oct 7, 2018

Super nice improvement, @flash-gordon! 👍🏼

flash-gordon merged commit 63de67d into master

flash-gordon deleted the feature/default-unit branch

October 7, 2018 13:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet