Fix full error messages

[stind]

Fixes #661

[solnic]

Thanks for the PR! There's one thing to tweak though. Please let me know if it's something you could take of.

[esparta]

Would need to warn about scope & signature changes?

[esparta]

message_text was marked as public on the API documentation:

https://rubydoc.info/gems/dry-validation/1.5.3/Dry/Validation/Messages/Resolver#message_text-instance_method

For compatibility reason a changing the scope to private and their signature would potentially break systems using this internally.

[stind]

That's a good point. I'll return the method back with the original signature, so the bug fix could be shipped in a patch version.

There is something to consider though:

• the interface is not consistent
  #message and #call expect path as a keyword argument
  #message_text expects it as a positional argument

• should #message and #message_text be public at all? Isn't it enough to have one public #call method?

[solnic]

@stind these shouldn't be public, it's a mistake in the yard docs, so don't worry about it. I'm 100% sure nobody is using this.

[dry-bot]

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

Complexity decreasing per file
==============================
+ lib/dry/validation/messages/resolver.rb  -1
         

Clones added
============
- spec/integration/messages/resolver_spec.rb  2
         

See the complete overview on Codacy