New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make context object available to exposures via matching keyword param #119

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
2 participants
@timriley
Copy link
Member

timriley commented Jan 23, 2019

Since context: is a reserved keyword param for View#call anyway, and since exposure dependencies already implicitly have the context (since they're Part objects by that point), it should be no harm to make the context available for those who want to use it directly when building their exposures.

@waiting-for-dev What do you reckon? :)

Make context object available to exposures via matching keyword param
Since `context:` is a reserved keyword param for `View#call` anyway, and since exposure dependencies already implicitly have the context (since they're Part objects by that point), it should be no harm to make the context available for those who want to use it directly when building their exposures.
@waiting-for-dev

This comment has been minimized.

Copy link
Contributor

waiting-for-dev commented Jan 24, 2019

Super-cool @timriley 😄

@timriley timriley merged commit 2297aa4 into master Jan 24, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@timriley timriley deleted the make-context-available-to-exposures branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment