Tweak compiler strategies #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In traversing the source syntax to apply rewrite rules in the compiler, we formerly would stop traversing a branch at a node (while continuing to explore other nodes) if the rule was successfully applied to that node. But there are cases where the same rewrite rule would apply at multiple levels of the same syntax node. In such cases, we would only rewrite (e.g. optimize) the highest level node where it applies, leaving the others unchanged, which could mean missed optimizations. Of the three former termination conditions: (1) transforming function returns false (2) leaf node is encountered (3) transformation is successful … we now only retain the former two, to ensure that the tree is fully traversed in applying rewrite rules. Fixes drym-org#154.
In last week's meeting we realized this was necessary, but I can't recall an example now of where it's needed.
This records the testcase but we don't yet have a good way to test what we are looking for here.
|
@dzoep reviewed during the Qi meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Tweak some strategies as discussed in the past:
Public Domain Dedication
(Why: The freely released, copyright-free work in this repository represents an investment in a better way of doing things called attribution-based economics. Attribution-based economics is based on the simple idea that we gain more by giving more, not by holding on to things that, truly, we could only create because we, in our turn, received from others. As it turns out, an economic system based on attribution -- where those who give more are more empowered -- is significantly more efficient than capitalism while also being stable and fair (unlike capitalism, on both counts), giving it transformative power to elevate the human condition and address the problems that face us today along with a host of others that have been intractable since the beginning. You can help make this a reality by releasing your work in the same way -- freely into the public domain in the simple hope of providing value. Learn more about attribution-based economics at drym.org, tell your friends, do your part.)