Feat/rn 0.71 backmerge #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the discussion here: wix#6618. ## Android - Colours are parsed natively. - Creating custom colour when a PlatformColor is passed to native. - Both light/dark values have the same res attribute resolved when `get` is called. ## IOS - Added a custom colour. - Changed storyboard splash screen. - Using `labelColor` as a test. CC: @yogevbd closes: wix#6618 Co-authored-by: Yogev Ben David <yogev132@gmail.com>
When testing the `registerModalAttemptedToDismissListener` event, I noticed that I had to set the `swipeToDismiss` flag to false. The docs currently falsely indicate it should be `true`
Modify flags for DecorView in the global main thread handler caused ui to freeze when calling `mergeOptions` inside useEffect. This happens on Samsung devices with Android 9, that seems it has issues internally since it is not reproduce on emulator and other devices including Samsungs with new android versions. The workaround was to set the flags in a task to run in the DecorView MessageQueue in order to ensure flags are set when the DecorView is ready internally to accept changes. Co-authored-by: Yogev Ben David <yogev132@gmail.com>
* Add test cases for new issues * handle pause/resume in modal stack * Delete OverlayManager.java * pass pause/resume to modals/overlayes - overlays should always get the events since they are on top - modals basically covers the whole view behind - all other layers can handle events in this order * Update OverlayManager.kt * Update Navigator.java * add tests for overCurrentContext mode * add peekDisplayedOverCurrentContext * call root when top modal is overCurrentContext Co-authored-by: Guy Carmeli <guyca@users.noreply.github.com>
Co-authored-by: Lawrence Dabir-Alai <lawrence.dabir-alai@klarna.com> Co-authored-by: Yogev Ben David <yogev132@gmail.com>
Co-authored-by: wixmobile <mobile1@wix.com>
…ewController (wix#7644) This caused a bug in our Wix app when presenting a modal while another one is dismissed. The presented modal was dismissed as well along with the one that was being dismissed.
Until now, invoking `Navigation.constants()` and `Navigation.constantsSync()` failed in our headless tests. This PR fix this and some lint issues.
…read (wix#7657) This fixes a crash happening in the Wix app, look like there's a race condition where the activity is destroyed and `navigator.onHostPause()`gets called too late. Most of times this shouldn't be delayed as it is called on the main thread.
Previously if an element was not found, then it would break out of the loop looking for further (possibly valid) shared element transitions. Now it'll continue the loop, which is the expected behavior.
This is helpful to troubleshoot test issues
… into feat/rn-0.71-backmerge
rahulfancode
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.