New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle aggregate for discriminators #135

Merged

dsanel merged 2 commits into dsanel:master from davellx:issue-130-aggregatewithdeleted-discriminators

Jun 13, 2023

Contributor

davellx commented Jun 12, 2023

This PR should handle the use Discriminators with aggregateWithDeleted.

Some things to notice :

I kept using var instead of let/const. It felt strange but I've seen a commit that show this style is intended.
I used destructuring, I think it should not be a probme on most Node.js server nowadays
I used Optional chaining, that is present in Node.js since v14. Tell me if it's a problem.
I added test for this case

I hope it helps.
David.


          Handle aggregate for discriminators

2e8fd0d

davellx mentioned this pull request

aggregateWithDeleted returns no result with Discriminators #130

Closed


          Small refactring for tests, CHANGELOG.md

59f1e81

dsanel merged commit 008ea81 into dsanel:master

18 checks passed

Owner

dsanel commented Jun 13, 2023

Nice work @davellx! Thx for help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet