Add typescript definitions #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@razbakov: Thank you very much for your contribution! We will get back to you as soon as we can, and hopefully get this merged and released in a few days! |
|
Hi and thanks for the PR! Appreciate it. Looks like the config object is using the aliased variables for version 1, so we'll keep it to this versioning scheme at least. These will be deprecated in the next major. |
|
We should probably have a look at this file, and maybe be as close to it as possible: https://github.com/keycloak/keycloak/blob/master/adapters/oidc/js/src/main/resources/keycloak.d.ts |
wchaws
approved these changes
Mar 5, 2021
|
@anderius Any update? |
|
No, the problem being that we don't yet use Typescript internally. We are happy to accept a contribution, but my comment above still stands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23