Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks to typescript / vue 3 support #73

Merged
merged 5 commits into from
May 18, 2021
Merged

Tweaks to typescript / vue 3 support #73

merged 5 commits into from
May 18, 2021

Conversation

baltom
Copy link
Contributor

@baltom baltom commented Apr 9, 2021

  • Added eslint
  • Fixed support for vue 2
  • Added 2 more examples
  • Updated readme file
  • Clean up of old sanitizeConfig types which is no longer used
  • removed loadUserInfo as it does not exist

@baltom
Copy link
Contributor Author

baltom commented Apr 9, 2021 •
edited

With this vue 2 projects seems to work fine as before. as in login-required works as intended, check-sso works good. and the reactiveness of $keycloak works great. Login/logout and updateToken (see examples)

For vue 3 typescript, it mostly seems to work. Typings is found, and you can use/reference the $keycloak object and see it's "members". however the reactiveness of the $keycloak object does not work. Investigating why that is.

It fixes #71 & #70

This was referenced Apr 9, 2021
Closed
Closed
Closed
Closed
chrisnruud
chrisnruud requested changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@chrisnruud chrisnruud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but the reactivity part seems to be a show stopper

README.md
Internally for Vue 3
* [reactive](https://v3.vuejs.org/guide/reactivity-fundamentals.html#declaring-reactive-state)

This object is reactive and will update with new tokens and other information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not yet reactive, then perhaps either fix root cause or change readme?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is reactive in v2 and should be in v3

README.md Show resolved Hide resolved
examples/hello-keycloak/package.json Show resolved Hide resolved
@anderius
Copy link
Contributor

The sanitizeConfig method of using the old configuration object was said to be deprecated in the next major release. That is this one, I guess? So we shouldd still keep it, but mark it deprecated?

@baltom
Copy link
Contributor Author

baltom commented Apr 20, 2021

The sanitizeConfig method of using the old configuration object was said to be deprecated in the next major release. That is this one, I guess? So we shouldd still keep it, but mark it deprecated?

It has been "marked" as deprecated in the readme for a while. So i was thinking of doing a major version update after this PR with said sanitizeConfig gone

anderius
anderius approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@anderius anderius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sanitizeConfig method of using the old configuration object was said to be deprecated in the next major release. That is this one, I guess? So we shouldd still keep it, but mark it deprecated?

It has been "marked" as deprecated in the readme for a while. So i was thinking of doing a major version update after this PR with said sanitizeConfig gone

The sanitizeConfig method of using the old configuration object was said to be deprecated in the next major release. That is this one, I guess? So we shouldd still keep it, but mark it deprecated?

It has been "marked" as deprecated in the readme for a while. So i was thinking of doing a major version update after this PR with said sanitizeConfig gone

My mistake! Then it is time to remove it.

examples/hello-keycloak/package.json Show resolved Hide resolved
README.md Show resolved Hide resolved
@baltom baltom merged commit b9ec0c1 into master May 18, 2021
@baltom baltom deleted the typescript_vue3_examples branch May 18, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisnruud chrisnruud chrisnruud requested changes

@anderius anderius anderius approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baltom @anderius @chrisnruud