Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls to the parent methods using dict as parent instead of object #44

Closed
wants to merge 1 commit into from

Conversation

olivecoder
Copy link
Contributor

The calls to the upper-class methods should use dict instead of object.
Maybe pedantic as there is no impact and it is unlikely to have the getattribute, delattr, and setattr methods overridden by dict, but this is the correct way anyway.

@dsc
Copy link
Owner

dsc commented Sep 20, 2024

Object is safer, given people might subclass.

@dsc dsc closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants