Skip to content

Commit

Permalink
Rename electron-updater to electron-updater-bin for now.
Browse files Browse the repository at this point in the history
  • Loading branch information
@dscalzi
dscalzi committed Oct 14, 2018
1 parent b93ecf2 commit e6874b5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion index.js
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Requirements
const {app, BrowserWindow, ipcMain} = require('electron')
const autoUpdater = require('electron-updater').autoUpdater
const autoUpdater = require('electron-updater-bin').autoUpdater
const ejse = require('ejs-electron')
const fs = require('fs')
const isDev = require('./app/assets/js/isdev')
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"discord-rpc": "^3.0.1",
"ejs": "^2.6.1",
"ejs-electron": "^2.0.3",
"electron-updater": "WesterosCraftCode/electron-updater-bin",
"electron-updater-bin": "git://github.com/WesterosCraftCode/electron-updater-bin",
"github-syntax-dark": "^0.5.0",
"jquery": "^3.3.1",
"mkdirp": "^0.5.1",
Expand Down

3 comments on commit e6874b5

@dscalzi
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed because electron-updater is a "reserved dependency" in the builder.

https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/util/packageMetadata.ts#L94

@ahadcove
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was waiting for the PR to be merged into the actual electron-builder repo, but it's looking like it may be a while. Did you have to get your users to manually install the next version so their updates would work with this branch? Or will the old update auto-update if you add this in the next version?

@dscalzi
Copy link
Owner Author

@dscalzi dscalzi commented on e6874b5 Oct 18, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've upgraded to electron 3 with the old electron-updater and shipped that to users, they will need to manually install as the updater will be broken. If the old version is still on electron 2, you should be fine.

Please sign in to comment.