-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename electron-updater to electron-updater-bin for now.
- Loading branch information
Showing
3 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6874b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed because electron-updater is a "reserved dependency" in the builder.
https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/util/packageMetadata.ts#L94
e6874b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was waiting for the PR to be merged into the actual electron-builder repo, but it's looking like it may be a while. Did you have to get your users to manually install the next version so their updates would work with this branch? Or will the old update auto-update if you add this in the next version?
e6874b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you've upgraded to electron 3 with the old electron-updater and shipped that to users, they will need to manually install as the updater will be broken. If the old version is still on electron 2, you should be fine.