Track depth to throw error if parsing is closed before all JSON objects are complete. Fixes issue #18. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good. Are you ok with me merging this? |
|
There are failures in Travis for Node 0.6 at the moment but looks like an ssl issue connecting to npm. Nothing in this PR should depend on Node versions. I say hit it! When you hit the merge button could you do an npm publish so I can depend projects on the fixed version? |
dscape
added a commit
that referenced
this pull request
Jan 16, 2014
Track depth to throw error if parsing is closed before all JSON objects are complete. Fixes issue #18.
|
I am trying but npm is borked. |
|
That'll explain the Travis failures I'm seeing everywhere at the moment. When I was working for Skype/MS last year I bugged everybody who might listen with the 'donate to NPM' link but to no avail. Ah well. Don't feel any huge pressure from me, I can wait until npm is feeling happy again. Hopefully shouldn't be sick for very long. |
|
its live :) |
|
Awsome! Cheers dude. |
jimhigson
added a commit
to jimhigson/oboe.js
that referenced
this pull request
Jan 16, 2014
…ng with incomplete JSON dscape/clarinet#20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.