Skip to content
This repository has been archived by the owner on Nov 5, 2018. It is now read-only.

Fix multipart inserts of attachments via Buffer #231

Closed
jo opened this issue Oct 30, 2014 · 8 comments
Closed

Fix multipart inserts of attachments via Buffer #231

jo opened this issue Oct 30, 2014 · 8 comments

Comments

@jo
Copy link
Contributor

jo commented Oct 30, 2014

Since #225 we can no longer use buffers in multipart uploads.

@jo
Copy link
Contributor Author

jo commented Oct 30, 2014

...because Buffer.byteLength expects a string.

@dscape
Copy link
Contributor

dscape commented Oct 30, 2014

@jo can you check the rewrite branch and tell me what you think?

@jo
Copy link
Contributor Author

jo commented Oct 30, 2014

And I thought I could dodge...

No - I am very happy about the fact that you did a rewrite! - Not that I have anything against the current code, I just love the crystal clarity of rewritten code ;)

I hope I'll find the time tomorrow to really look at the code.

@jo jo closed this as completed in 7e42a1a Oct 31, 2014
@jo
Copy link
Contributor Author

jo commented Nov 6, 2014

@dscape could you do an intermediate release with this fix? Asking because people running into this issue right now on stackoverflow

@dscape
Copy link
Contributor

dscape commented Nov 6, 2014

what's your npm username? i'll add you so you can release

@jo
Copy link
Contributor Author

jo commented Nov 6, 2014

jo

@dscape
Copy link
Contributor

dscape commented Nov 6, 2014

$ npm own ls
npm http GET https://registry.npmjs.org/nano
npm http 200 https://registry.npmjs.org/nano
dscape <nunojobpinto@gmail.com>
pgte <pedro.teixeira@gmail.com>
jo <schmidt@netzmerk.com>

@jo
Copy link
Contributor Author

jo commented Nov 6, 2014

Thanks!

[jo@localhost nano]$ npm publish
+ nano@5.12.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants