Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DnsRecordNs: Implemented as a class-based resource #254

Merged
merged 7 commits into from
Apr 23, 2021

Conversation

Sudman1
Copy link
Contributor

@Sudman1 Sudman1 commented Apr 22, 2021

Pull Request (PR) description

Implements a class-based solution for managing NS records - to include implementation of managing scoped records.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help. Does not use schema.mof file. Parameter Descriptions not updated in the README.md, as that has moved to the Wiki.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #254 (b529d3d) into main (97f6ef7) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #254   +/-   ##
===================================
  Coverage    90%    91%           
===================================
  Files        36     38    +2     
  Lines      1476   1546   +70     
===================================
+ Hits       1337   1407   +70     
  Misses      139    139           
Impacted Files Coverage Δ
source/Classes/003.DnsRecordMx.ps1 100% <ø> (ø)
source/Private/Get-LocalizedDataRecursive.ps1 100% <ø> (ø)
source/Classes/003.DnsRecordNs.ps1 100% <100%> (ø)
source/Classes/004.DnsRecordNsScoped.ps1 100% <100%> (ø)

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 19 of 20 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Sudman1)

@johlju johlju merged commit b17d68f into dsccommunity:main Apr 23, 2021
@johlju
Copy link
Member

johlju commented Apr 23, 2021

@Sudman1 Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DnsRecordNs: New resource proposal
2 participants