Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSQLServerEndpointPermission: Need to remove ShouldProcess from code #231

Closed
johlju opened this issue Nov 29, 2016 · 0 comments · Fixed by #485
Closed

xSQLServerEndpointPermission: Need to remove ShouldProcess from code #231

johlju opened this issue Nov 29, 2016 · 0 comments · Fixed by #485
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Nov 29, 2016

Details of the scenario you try and problem that is occurring:
This resource is using non supported functions. Best practices are to not use ShouldProcess in DSC resources.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added easy fix enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Nov 29, 2016
@johlju johlju changed the title MSFT_xSQLServerEndpointPermission: Need to remove ShouldProcess from code xSQLServerEndpointPermission: Need to remove ShouldProcess from code Dec 12, 2016
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Apr 10, 2017
@johlju johlju self-assigned this Apr 10, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 10, 2017
@johlju
- Changes to xSQLServerEndpointPermission
20b7d59 
  - Cleaned up code (issue dsccommunity#257 and issue dsccommunity#231)
@johlju johlju mentioned this issue Apr 10, 2017
Merged
5 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue Apr 10, 2017
@johlju
- Changes to xSQLServerEndpointPermission
17f6a33 
  - Cleaned up code (issue dsccommunity#257 and issue dsccommunity#231)
johlju added a commit that referenced this issue Apr 15, 2017
@johlju
xSQLServerEndpointPermission: Removed dependency of SQLPS provider
be86de3 
- Changes to xSQLServerEndpointPermission
  - Added description to the README.md
  - Cleaned up code (issue #257 and issue #231)
  - Now the default value for Ensure is 'Present'.
  - Removed dependency of SQLPS provider (issue #483).
  - Refactored tests so they use less code.
@johlju johlju removed their assignment Apr 15, 2017
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xSQLServerEndpointPermission: Removed dependency of SQLPS provider johlju/SqlServerDsc
1 participant
@johlju