Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSManListener: Fix Find-Certificate Verbose Messages #56

Merged
merged 4 commits into from
Jan 1, 2020

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Dec 22, 2019

Pull Request (PR) description

This PR fixes the following Find-Certificate verbose messages by swapping the $Issuer and $Subject parameters of the relevant Write-Verbose commands in the Find-Certificate function.

  • FindCertificateMessage
  • FindCertificateAlternateMessage

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@PlagueHO
Copy link
Member

Hi @X-Guardian - can you resolve the conflicts on this one and then I'll review and merge.

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit f7c414a into dsccommunity:master Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WSManListener: Incorrect Find-Certificate Verbose Messages
2 participants