Port FixMsiPackageTests from PSDscResources #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #627 +/- ##
===================================
Coverage 75% 75%
===================================
Files 28 28
Lines 4187 4187
Branches 4 4
===================================
Hits 3147 3147
Misses 1036 1036
Partials 4 4 |
|
Hey @PlagueHO , can you review this one when you get a chance? Thanks. |
PlagueHO
approved these changes
Jun 4, 2019
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Ports the fixes from: PowerShell/PSDscResources#157.
These fixed: PowerShell/PSDscResources#142.
Fixes issue where MsiPackage Integration tests fail if the test HttpListener
fails to start. Moves the test HttpListener objects to dynamically assigned,
higher numbered ports to avoid conflicts with other services, and also checks
to ensure that the ports are available before using them. Adds checks to
ensure that no outstanding HTTP server jobs are running before attempting to
setup a new one. Also adds additional instrumentation to make it easier to
troubleshoot issues with the test HttpListener objects in the future.
This Pull Request (PR) fixes the following issues
None
Task list
CHANGELOG.md. Entry should say what was changed, and how that affects
users (if applicable).
and comment-based help.
appropriate.
DSC Resource Testing Guidelines.
DSC Resource Testing Guidelines.
DSC Resource Style Guidelines and Best Practices
This change is