git-path-in-subdir-v2
dscho
tagged this
10 Feb 15:32
The bug that bit me (hard!) and that triggered not only a long series of curses but also my writing a patch and sending it to the list was that `git rev-parse --git-path HEAD` would give *incorrect* output when run in a subdirectory of a regular checkout, but *correct* output when run in a subdirectory of an associated *worktree*. I had tested the script in question quite a bit, but in a worktree. And in production, it quietly did exactly the wrong thing. Relative to v1 of the then-single patch, this changed: - the patch now covers also --git-common-dir and --shared-index-path - the output is now a relative path when git_dir is relative - I plucked the tests from Mike's patch series and dropped my ad-hoc test from t0060. - While at it, I fixed Mike's test that assumed that the objects/ directory lives in .git/worktrees/<name>/objects/. Johannes Schindelin (1): rev-parse: fix several options when running in a subdirectory Michael Rappazzo (1): rev-parse tests: add tests executed from a subdirectory builtin/rev-parse.c | 15 +++++++++++---- t/t1500-rev-parse.sh | 28 ++++++++++++++++++++++++++++ t/t1700-split-index.sh | 17 +++++++++++++++++ t/t2027-worktree-list.sh | 10 +++++++++- 4 files changed, 65 insertions(+), 5 deletions(-) base-commit: 6e3a7b3398559305c7a239a42e447c21a8f39ff8 Submitted-As: https://public-inbox.org/git/cover.1486740772.git.johannes.schindelin@gmx.de In-Reply-To: https://public-inbox.org/git/50fe3ea3302c40f4c96eaa5a568837e3334f9dc4.1486555851.git.johannes.schindelin@gmx.de
Assets 2
-
2017-02-10T15:32:53Z -
2017-02-10T15:32:53Z -