putty-w-args-v2
dscho
tagged this
26 Jan 14:50
We already handle PuTTY's plink and TortoiseGit's tortoiseplink in GIT_SSH by automatically using the -P option to specify ports, and in tortoiseplink's case by passing the --batch option. For users who need to pass additional command-line options to plink, this poses a problem: the only way to do that is to use GIT_SSH_COMMAND, but Git does not handle that specifically, so those users have to manually parse the command-line options passed via GIT_SSH_COMMAND and replace -p (if present) by -P, and add --batch in the case of tortoiseplink. This is error-prone and a bad user experience. To fix this, the changes proposed in this patch series introduce handling this by splitting the GIT_SSH_COMMAND value and treating the first parameter with the same grace as GIT_SSH. To counter any possible misdetection, the user can also specify explicitly via GIT_SSH_VARIANT or ssh.variant which SSH variant they are using. This is v2 of the patch, now turned patch series. Relative to v1, it integrates Junio's cleanup patch and Segev's follow-up Pull Request that introduces the GIT_SSH_VARIANT and ssh.variant settings to override Git's autodetection manually. Junio C Hamano (1): connect: rename tortoiseplink and putty variables Segev Finer (2): connect: handle putty/plink also in GIT_SSH_COMMAND connect: Add the envvar GIT_SSH_VARIANT and ssh.variant config Documentation/config.txt | 7 +++++ Documentation/git.txt | 7 +++++ connect.c | 66 +++++++++++++++++++++++++++++++++++------------- t/t5601-clone.sh | 41 ++++++++++++++++++++++++++++++ 4 files changed, 104 insertions(+), 17 deletions(-) base-commit: 4e59582ff70d299f5a88449891e78d15b4b3fabe Submitted-As: https://public-inbox.org/git/cover.1485442231.git.johannes.schindelin@gmx.de In-Reply-To: https://public-inbox.org/git/2ff29a4d00e0e13d460122d8008e762361ca90aa.1483358673.git.johannes.schindelin@gmx.de
Assets 2
-
2017-01-26T14:50:31Z -
2017-01-26T14:50:31Z -