Avoid calling fsync on closed fd

dscho · Mar 31, 2011 · fd02eb2 · fd02eb2
1 parent 7eae2b4
commit fd02eb2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/msys/rt/src/winsup/cygwin/ChangeLog.MSYS b/msys/rt/src/winsup/cygwin/ChangeLog.MSYS
@@ -1,3 +1,8 @@
+2011.03.31  Charles Wilson  <mingw@cwilson.fastmail.fm>
+
+	* syscall.cc (_close): Avoid calling fsync() on file descriptor
+	we just closed.
+
 2010.09.28  Cesar Strauss  <cestrauss@gmail.com>
 
 	* include/cygwin/version.h: Increment version to 1.0.16.

diff --git a/msys/rt/src/winsup/cygwin/syscalls.cc b/msys/rt/src/winsup/cygwin/syscalls.cc
@@ -507,7 +507,6 @@ _close (int fd)
     {
       SetResourceLock (LOCK_FD_LIST,WRITE_LOCK|READ_LOCK," close");
       res = cygheap->fdtab[fd]->close ();
-      fsync(fd);
       cygheap->fdtab.release (fd);
       ReleaseResourceLock (LOCK_FD_LIST,WRITE_LOCK|READ_LOCK," close");
     }