Address comments, fix test (idaholab#24645)

dschwen · Jun 20, 2023 · 38e9f82 · 38e9f82
1 parent d173f3e
commit 38e9f82
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 29 deletions.
diff --git a/framework/src/markers/BoundaryMarker.C b/framework/src/markers/BoundaryMarker.C
@@ -44,6 +44,7 @@ BoundaryMarker::computeElementMarker()
 {
   if (_distance == 0.0)
   {
+    // is the current element member of any selected boundary element set?
     for (const auto boundary : _boundary_ids)
       if (_mesh.isBoundaryElem(_current_elem->id(), boundary))
         return _mark;
@@ -58,6 +59,11 @@ BoundaryMarker::computeElementMarker()
       if (it != _bnd_elem_ids.end())
         for (const auto id : it->second)
         {
+          // shortcut if we are checing the current element itself
+          if (id == _current_elem->id())
+            return _mark;
+
+          // otherwise compute distance to the boundary elements
           const auto elem = _mesh.elemPtr(id);
           const auto r = _current_elem->vertex_average() - elem->vertex_average();
           if (r.norm() < _distance)

diff --git a/test/tests/markers/boundary_marker/adjacent.i b/test/tests/markers/boundary_marker/adjacent.i
@@ -1,12 +1,3 @@
-###########################################################
-# This is a test of the Mesh Marker System. It marks
-# elements with flags indicating whether they should be
-# refined, coarsened, or left alone. This system
-# has the ability to use the Mesh Indicator System.
-#
-# @Requirement F2.50
-###########################################################
-
 [Mesh]
   type = GeneratedMesh
   dim = 2

diff --git a/test/tests/markers/boundary_marker/distance.i b/test/tests/markers/boundary_marker/distance.i
@@ -1,12 +1,3 @@
-###########################################################
-# This is a test of the Mesh Marker System. It marks
-# elements with flags indicating whether they should be
-# refined, coarsened, or left alone. This system
-# has the ability to use the Mesh Indicator System.
-#
-# @Requirement F2.50
-###########################################################
-
 [Mesh]
   type = GeneratedMesh
   dim = 2

diff --git a/test/tests/markers/boundary_marker/multiple.i b/test/tests/markers/boundary_marker/multiple.i
@@ -1,12 +1,3 @@
-###########################################################
-# This is a test of the Mesh Marker System. It marks
-# elements with flags indicating whether they should be
-# refined, coarsened, or left alone. This system
-# has the ability to use the Mesh Indicator System.
-#
-# @Requirement F2.50
-###########################################################
-
 [Mesh]
   type = GeneratedMesh
   dim = 2

diff --git a/test/tests/userobjects/geometry_snap/tests b/test/tests/userobjects/geometry_snap/tests
@@ -12,9 +12,9 @@
   [block]
     type = 'Exodiff'
     input = 'block.i'
-    exodiff = 'block.e-s004'
+    exodiff = 'block_out.e-s004'
     issues = '#24645'
-    requirement = "The system shall support 'snapping' or moving new nodes in lower dimensioanl "
+    requirement = "The system shall support 'snapping' or moving new nodes in lower dimensional "
                   "subdomains created by mesh adaptivity to the surface of a geometric sphere to "
                   "capture high fidelity features on curved geometries."
   []