feat: Setup Firebase Google OAuth #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riteshsp2000
requested changes
Sep 15, 2021
| @@ -33,7 +33,7 @@ | |||
| "@material-ui/core": "^4.12.3", | |||
| "@material-ui/icons": "^4.11.2", | |||
| "@material-ui/styles": "^4.11.4", | |||
| "firebase": "^9.0.2", | |||
| "firebase": "8.10.0", | |||
| "gatsby": "^3.12.1", | |||
There was a problem hiding this comment.
why did you downgrade the version?
|
@sambit-sankalp. Hold on man, without even discussing what all is to be there, you are proceeding ahead |
| .signInWithPopup(provider) | ||
| .then((result) => { | ||
| dispatch({ type: LOGIN_SUCCESS }); | ||
| var user = result.user; |
Comment on lines
+5
to
+9
| const [instance, setInstance] = useState(null); | ||
| useEffect(() => { | ||
| setInstance(getFirebase()); | ||
| }, []); | ||
| return instance; |
There was a problem hiding this comment.
Why do we need to use useEffect and useState here?
Can't we do the following?
const [instance] = useState(getFirebase());
return instance;
There was a problem hiding this comment.
Yes, we can use do that also... I will take care of it.
| @@ -0,0 +1,4 @@ | |||
| export const AUTH_REQUEST = "AUTH_REQUEST"; | |||
| export const LOGIN_SUCCESS = "LOGIN_SUCCESS"; | |||
| export const AUTH_FAIL = "LOGINAUTH"; | |||
There was a problem hiding this comment.
Sure about the value of this string?
There was a problem hiding this comment.
Okay bhaiya, I will correct it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
Fixes #7
❤️Thank you!
Post merge checklist