Skip to content
This repository has been archived by the owner on Dec 16, 2020. It is now read-only.

surface errors from bridgy to user #21

Closed
snarfed opened this issue Jan 25, 2017 · 10 comments
Closed

surface errors from bridgy to user #21

snarfed opened this issue Jan 25, 2017 · 10 comments

Comments

@snarfed
Copy link

snarfed commented Jan 25, 2017

based on this ongoing conversation with cdevroe: https://chat.indieweb.org/2017-01-25/1485372011628000

... it sounds like errors from bridgy, ie non -2xx responses and their bodies, are currently dropped on the floor and nor shown to the user. it'd be nice to show them at some point. :P

specifically the error here from attempting to publish :

Couldn't find link to brid.gy/publish/twitter

log: https://brid.gy/log?start_time=1485371674&key=aglzfmJyaWQtZ3lyOgsSDVB1Ymxpc2hlZFBhZ2UiE2h0dHA6Ly9jZGV2cm9lLmNvbS8MCxIHUHVibGlzaBiAgICAgICACgw

docs: https://brid.gy/about#webmentions

(btw, the plugin should probably add this link itself if necessary, right?)

i hate to say it, but the easiest way to surface errors is probably to switch from async cron to synchronous, so you have the response and can show it to the user right then.

thanks again for all your work on this plugin!

@dshanske
Copy link
Owner

I just switched to async, partly because of an odd other issue. But I think I can take a page from SNAP on how they handle it. In the last update, the error is returned, but not acted on.

@dshanske
Copy link
Owner

I think I have to figure out how the link is not going when the Webmention is. I never could reproduce in testing

1 similar comment
@dshanske
Copy link
Owner

I think I have to figure out how the link is not going when the Webmention is. I never could reproduce in testing

@dshanske
Copy link
Owner

And @snarfed, the plugin is merely a UI for the wonderful service you built and maintain.

@snarfed
Copy link
Author

snarfed commented Jan 25, 2017

thanks for the kind words!

i have a fair amount of experience with async vs sync, and honestly, the code and UX will both be much simpler and better if you go back to sync. it will cost a second or two in latency per publish, but i'm pretty sure it'll be worth it in this case. just my 2¢.

@dshanske
Copy link
Owner

Actually I did it partially because the setting of the manual fill in for mf2_syndication kept conflicting with the automatic one from the Webmention. Other ways to solve it.

@dshanske
Copy link
Owner

Deploying a fix for this shortly.

@snarfed
Copy link
Author

snarfed commented Jan 9, 2018

more complaints about this: https://chat.indieweb.org/2018-01-09#t1515524954448400

@dshanske
Copy link
Owner

I think I have fixed this in the latest version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants