chore: Updates for #909.

dsherret · Jan 31, 2021 · 58ec871 · 58ec871
1 parent 398d946
commit 58ec871
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 8 deletions.
diff --git a/packages/bootstrap/lib/ts-morph-bootstrap.d.ts b/packages/bootstrap/lib/ts-morph-bootstrap.d.ts
@@ -205,7 +205,12 @@ export interface ProjectOptions {
     fileSystem?: FileSystemHost;
     /** Creates a resolution host for specifying custom module and/or type reference directive resolution. */
     resolutionHost?: ResolutionHostFactory;
-    isKnownTypesPackageName?: ts.LanguageServiceHost['isKnownTypesPackageName'];
+    /**
+     * Unstable and will probably be removed in the future.
+     * I believe this option should be internal to the library and if you know how to achieve
+     * that then please consider submitting a PR.
+     */
+    isKnownTypesPackageName?: ts.LanguageServiceHost["isKnownTypesPackageName"];
 }
 
 /** Project that holds source files. */

diff --git a/packages/bootstrap/src/Project.ts b/packages/bootstrap/src/Project.ts
@@ -23,7 +23,12 @@ export interface ProjectOptions {
     fileSystem?: FileSystemHost;
     /** Creates a resolution host for specifying custom module and/or type reference directive resolution. */
     resolutionHost?: ResolutionHostFactory;
-    isKnownTypesPackageName?: ts.LanguageServiceHost['isKnownTypesPackageName'];
+    /**
+     * Unstable and will probably be removed in the future.
+     * I believe this option should be internal to the library and if you know how to achieve
+     * that then please consider submitting a PR.
+     */
+    isKnownTypesPackageName?: ts.LanguageServiceHost["isKnownTypesPackageName"];
 }
 
 /**
@@ -153,7 +158,7 @@ export class Project {
             getNewLine: () => newLineKind,
             resolutionHost: resolutionHost || {},
             getProjectVersion: () => this._sourceFileCache.getProjectVersion().toString(),
-            isKnownTypesPackageName: options.isKnownTypesPackageName
+            isKnownTypesPackageName: options.isKnownTypesPackageName,
         });
         this.languageServiceHost = languageServiceHost;
         this.compilerHost = compilerHost;

diff --git a/packages/common/src/compiler/createHosts.ts b/packages/common/src/compiler/createHosts.ts
@@ -21,11 +21,9 @@ export interface CreateHostsOptions {
     /** Provides the current project version to be used to tell if source files have
      * changed. Provide this for a performance improvement. */
     getProjectVersion?: () => string;
-    isKnownTypesPackageName?: ts.LanguageServiceHost['isKnownTypesPackageName'];
+    isKnownTypesPackageName?: ts.LanguageServiceHost["isKnownTypesPackageName"];
 }
 
-const returnTrue = () => true;
-
 /**
  * Creates a language service host and compiler host.
  * @param options - Options for creating the hosts.
@@ -68,8 +66,8 @@ export function createHosts(options: CreateHostsOptions) {
                 );
             }
         },
-        isKnownTypesPackageName: isKnownTypesPackageName || returnTrue,
-        useCaseSensitiveFileNames: returnTrue,
+        isKnownTypesPackageName,
+        useCaseSensitiveFileNames: () => true,
         readFile: (path, encoding) => {
             const standardizedPath = transactionalFileSystem.getStandardizedAbsolutePath(path);
             if (sourceFileContainer.containsSourceFileAtPath(standardizedPath))