Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename methods on main api #170

Closed
dsherret opened this issue Dec 13, 2017 · 0 comments
Closed

Rename methods on main api #170

dsherret opened this issue Dec 13, 2017 · 0 comments

Comments

@dsherret
Copy link
Owner

dsherret commented Dec 13, 2017

Add:

  • createSourceFile(filePath: string): SourceFile; -- Sometimes it's nice to just create an empty source file.

Change:

  • getOrAddSourceFile(filePath: string): SourceFile; -> addExistingSourceFile(filePath: string): SourceFile; - Should say "existing" to make it clear that this is an existing source file from the disk.
  • addSourceFiles(...fileGlobs: string[]): void -> addExistingSourceFiles(...fileGlobs: string[]): SourceFile[] -- Return the source files that matched
  • addSourceFileFromText(filePath: string, sourceFileText: string): SourceFile; -> createSourceFile(filePath: string, sourceFileText: string): SourceFile;
  • addSourceFileFromStructure(filePath: string, structure: SourceFileStructure): SourceFile; -> createSourceFile(filePath: string, structure: SourceFileStructure): SourceFile;
@dsherret dsherret added this to the Version 4.0 milestone Dec 13, 2017
dsherret added a commit that referenced this issue Dec 13, 2017
BREAKING CHANGE - Renamed methods for creating & adding source files. See #170 for details.
dsherret added a commit that referenced this issue Dec 13, 2017
BREAKING CHANGE: Renamed methods for creating & adding source files. See #170 for details.
dsherret added a commit that referenced this issue May 14, 2019
BREAKING CHANGE: Renamed methods for creating & adding source files. See #170 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant