Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting a source file by name or condition should walk up directory structure #174

Closed
dsherret opened this issue Dec 16, 2017 · 0 comments
Closed

Getting a source file by name or condition should walk up directory structure #174

dsherret opened this issue Dec 16, 2017 · 0 comments
Labels
domain: navigation
Milestone
ts-simple-ast: Ve...

Comments

@dsherret
Copy link
Owner

Right now, when getting a source file by name or condition, it returns the first source file that matches based on which was added first. That's not ideal. With #169 implemented, it will be simple to change this to always check a source file in an ancestor directory for a match before checking the descendant directories.
@dsherret dsherret added this to the Version 4.0 milestone Dec 16, 2017
dsherret added a commit that referenced this issue Dec 17, 2017
@dsherret
feat: #174 - Getting a source file by name or condition walks directo…
e4f4b45 
…ries.

This means that files stored in more parent directories will be matched before files way down in the directory structure.
dsherret added a commit that referenced this issue May 14, 2019
@dsherret
feat: #174 - Getting a source file by name or condition walks directo…
c74b001 
…ries.

This means that files stored in more parent directories will be matched before files way down in the directory structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: navigation
Projects
None yet
Milestone
ts-simple-ast: Version 4.0
Development

No branches or pull requests
1 participant
@dsherret