Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Statement classes #204

Closed
dicarlo2 opened this issue Jan 8, 2018 · 6 comments
Closed

Add missing Statement classes #204

dicarlo2 opened this issue Jan 8, 2018 · 6 comments

Comments

@dicarlo2
Copy link
Contributor

dicarlo2 commented Jan 8, 2018

Hi @dsherret, first off, thanks for creating a great library, it's proven to be invaluable for a project I'm currently working on. There are some missing wrappers that I'd like to see in the library. I need this rather urgently, so I'll likely publish my own package while waiting for reviews/release, but I'd love to contribute back to the library. I don't see contributor guidelines, so I'm going to just mimic some of your previous commits.

dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 8, 2018
dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 8, 2018
@dsherret
Copy link
Owner

dsherret commented Jan 8, 2018

Sounds great! Yeah, I was thinking last night about how I can make contributing easier. I'm going to devote some time to that over the next few weeks and clean up some of the internals in the library so things are more straightforward.

dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 8, 2018
dsherret added a commit that referenced this issue Jan 8, 2018
dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 9, 2018
dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 9, 2018
dsherret added a commit that referenced this issue Jan 9, 2018
feat: #204 - Add IterationStatement, Do, ForIn, ForOf, For, While
@dsherret
Copy link
Owner

dsherret commented Jan 9, 2018

@dicarlo2 I'll do a minor release when I get home tonight.

dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 9, 2018
dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 9, 2018
dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 9, 2018
@dicarlo2
Copy link
Contributor Author

dicarlo2 commented Jan 9, 2018

With these prs all statements should be there except WithStatement, honestly not going to bother because it's not valid typescript or strict javascript, so it basically shouldn't ever show up in a program.

dsherret added a commit that referenced this issue Jan 10, 2018
feat #204: Add Empty, Debugger and NotEmitted Statement
dsherret added a commit that referenced this issue Jan 10, 2018
feat #204: Add ThrowStatement and TryStatement
dsherret added a commit that referenced this issue Jan 10, 2018
dsherret added a commit that referenced this issue Jan 10, 2018
@dsherret
Copy link
Owner

dsherret commented Jan 10, 2018

@dicarlo2 I was feeling up for it so I went ahead and added WithStatement. I'm thinking perhaps someone in the future might want to write a script that automatically removes all WithStatements from an application.

Edit: Also, I removed the fill method on ForOfStatement for the time being. That should be more developed for it to be a feature... I'll add it back in the future probably.

dsherret added a commit that referenced this issue Jan 10, 2018
I might add this back in the future.
dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 10, 2018
dsherret added a commit that referenced this issue Jan 10, 2018
feat #204: Add Break, Continue, Default, Labeled and Switch Statements
dsherret added a commit that referenced this issue Jan 10, 2018
@dsherret
Copy link
Owner

dsherret commented Jan 10, 2018

I believe this is implemented now. Closing.

This will be available in 5.4.0. I'm just building and publishing it now.

@dicarlo2
Copy link
Contributor Author

Thanks for the quick reviews!

dsherret pushed a commit that referenced this issue May 14, 2019
dsherret added a commit that referenced this issue May 14, 2019
dsherret added a commit that referenced this issue May 14, 2019
feat: #204 - Add IterationStatement, Do, ForIn, ForOf, For, While
dsherret added a commit that referenced this issue May 14, 2019
feat #204: Add Empty, Debugger and NotEmitted Statement
dsherret added a commit that referenced this issue May 14, 2019
feat #204: Add ThrowStatement and TryStatement
dsherret added a commit that referenced this issue May 14, 2019
dsherret added a commit that referenced this issue May 14, 2019
dsherret added a commit that referenced this issue May 14, 2019
I might add this back in the future.
dsherret added a commit that referenced this issue May 14, 2019
feat #204: Add Break, Continue, Default, Labeled and Switch Statements
dsherret added a commit that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants