Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Expression classes #213

Closed
dicarlo2 opened this issue Jan 9, 2018 · 5 comments
Closed

Add missing Expression classes #213

dicarlo2 opened this issue Jan 9, 2018 · 5 comments

Comments

@dicarlo2
Copy link
Contributor

dicarlo2 commented Jan 9, 2018

No description provided.

@dsherret
Copy link
Owner

If you work on this, would you mind moving the expressions to their own folder? Right now they're in compiler/common, but it would be better if they were moved to compiler/expression.

dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 10, 2018
dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 10, 2018
dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 10, 2018
dicarlo2 added a commit to dicarlo2/ts-simple-ast that referenced this issue Jan 10, 2018
dsherret added a commit that referenced this issue Jan 11, 2018
feat #213: Add missing Expression classes
dsherret added a commit that referenced this issue Jan 11, 2018
Also add literalLikeNodeTests.ts
dsherret added a commit that referenced this issue Jan 11, 2018
Also add literalLikeNodeTests.ts
@dsherret
Copy link
Owner

dsherret commented Jan 11, 2018

@dicarlo2 can we can close this issue now?

Thanks once again for all your help! You did a great job here... I barely had to give any feedback.

@dicarlo2
Copy link
Contributor Author

Yea, I'm pretty sure this is complete, if I missed any I'll open another issue.

@dicarlo2
Copy link
Contributor Author

Thanks again for the speedy reviews!

@dsherret
Copy link
Owner

dsherret commented Jan 11, 2018

Cool, this is now released in v5.5.

By the way, fun fact: Node.d.ts is over 15,000 lines long since there's so many new wrapped nodes... the release took 10 minutes to run in order to generate all the overloads (ex. getFirstChildIfKind(kind: ts.SyntaxKind.Block): compiler.Block | undefined;). I think I'm going to make the js docs a single line. Also, in the future I'm going to need to work on improving the performance so that it's a bit quicker when working on large files.

dsherret added a commit that referenced this issue May 14, 2019
feat #213: Add missing Expression classes
dsherret added a commit that referenced this issue May 14, 2019
Also add literalLikeNodeTests.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants