Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when a node is constructed outside the library #218

Closed
dsherret opened this issue Jan 10, 2018 · 2 comments
Closed

Throw an error when a node is constructed outside the library #218

dsherret opened this issue Jan 10, 2018 · 2 comments
Labels
enhancement

Comments

@dsherret
Copy link
Owner

This is based on #217. It would be good to throw an error when someone uses the constructor outside the library and give them an explanation about why they can't do that.
@dsherret dsherret added this to the Version 6.0 milestone Jan 10, 2018
@Jack-Works
Copy link

Can't those constructors to be a node factory when they are called of the library?

@dsherret dsherret removed this from the Version 6.0 milestone Jan 13, 2018
@dsherret
Copy link
Owner Author

@Jack-Works Yes, perhaps in the future if #176 is implemented.

dsherret added a commit that referenced this issue Jan 13, 2018
@dsherret
fix: #218 - Throw an error when a node is constructed outside the lib…
74fa8c1 
…rary.
dsherret added a commit that referenced this issue May 14, 2019
@dsherret
fix: #218 - Throw an error when a node is constructed outside the lib…
fb05e0c 
…rary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsherret @Jack-Works