Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexSignatureDeclaration suggestions #245

Closed
2 tasks done
kjpou1 opened this issue Feb 9, 2018 · 2 comments
Closed
2 tasks done

IndexSignatureDeclaration suggestions #245

kjpou1 opened this issue Feb 9, 2018 · 2 comments

Comments

@kjpou1
Copy link

kjpou1 commented Feb 9, 2018

Hey David

Thanks for the wrapping and have a couple of suggestions after incorporating it.

The following might be useful as the IndexSignatureDeclaration looks more or less like a Property.

  • getModifiers() => <ModifierableNode>
  • isReadonly() => <ReadonlyableNode>

Not sure if anyone else will find them useful and I have worked around them.

Thanks again

@dsherret
Copy link
Owner

Thanks! I forgot it could have a readonly keyword... it's pretty simple to add so I just did a quick release. This is available in 6.12.0.

@kjpou1
Copy link
Author

kjpou1 commented Feb 10, 2018

Thanks @dsherret. Works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants