getSourceFiles returning multiple instances of the same file

[crisbeto]

I'm sorry for the vague report, but this is part of a larger project and I haven't been able to isolate the issue. I have a setup that looks like this:

const project = new Project({
  useVirtualFileSystem: true
});

glob(someFilePattern).forEach(filePath => {
  project.createSourceFile(filePath, readFileSync(filePath).toString());
});

console.log(project.getSourceFiles().map(sf => sf.getFilePath()));

In the console.log at the end I get an array that has multiple instances of each file (for a 42-file project I get back 663 results), e.g. the array looks like ['foo.ts', 'bar.ts', 'foo.ts', 'bar.ts']. A few notes:

• I'm confident that the logic that creates the source files in the first place doesn't have any duplicates, and even if it did, ts-simple-ast would throw an error if I tried to create the file again.
• This started happening after updating from 10.2.0 to 12.4.0.
• The references in the array returned by getSourceFiles are all pointing to the same object which means that it's probably not creating multiple instances of the same file.
• The issue can be worked around using getSourceFiles('**/*.ts').

[dsherret]

Hmmm that’s strange. Usually I’m really fast at fixing bugs, but unfortunately I’m moving this week so I’ll take a look sometime next week.

[cancerberoSgx]

Hey @crisbeto , just out of curiosity, since I can't reproduce this, could you share the value of someFilePattern and more or less the structure of the current folder ? is it a TypeScript project ? does it have tsconfig.json and package.json files ? what happen if you run it using absolute glob from another folder ? What happens if you add a minimal compilerOptions ? :

compilerOptions: {
        target: ScriptTarget.ES3
    }

Thanks

[dsherret]

It makes sense that it's a recent bug because I did some refactoring in this area recently. I haven't been able to reproduce it though, but I will do a review of the code again soon and I should be able to find the problem. Regardless, I'll submit a change that will cause an error to be throw in case it ends up in this state and that will help us catch this situation.

Unfortunately since my move I haven't been able to setup my desktop at home because I'm doing some renovations. Hopefully I'll be able to set it up this weekend and then look into this further. I'm looking forward to getting back to work on this project soon... but my home is a construction site at the moment (getting close to being done).

[dominique-mueller]

I am experiencing the same issue, suddenly 133 files become 135, two files are duplicate. Also, I can confirm that the workaround of selecting source files using getSourceFiles( "**/*.ts" ) works.

[dsherret]

@crisbeto @dominique-mueller I didn't mean to close this just yet. Since I wasn't able to reproduce this could you see if the latest fix in 12.4.1 resolved this issue? Thanks!

Also, sorry for the delay. I finally got my desk setup last night.

[dominique-mueller]

I did upgrade to 12.5.0 right away, and the issue no longer appears in my project! Thanks for the quick fix!

[crisbeto]

I can also confirm that the issue is fixed. Thank you @dsherret!