Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting isAbstract:true on a method still puts in a blank implementation #356

Closed
joseph-whiting opened this issue Jul 5, 2018 · 2 comments
Labels

Comments

@joseph-whiting
Copy link

When including a method in a declaration of abstract class, providing isAbstract: true still produces an empty implementation, like

abstract class {
   abstract myMethod() {}
}

instead it should not provide an implementation

@dsherret dsherret added the bug label Jul 5, 2018
@dsherret
Copy link
Owner

dsherret commented Jul 5, 2018

Ah yes thanks for reporting! This was actually fixed by @cancerberoSgx in this PR, but it hasn't been merged yet https://github.com/dsherret/ts-simple-ast/pull/346/files#diff-9428f443549f69ecf41f4d9aeaa833daR31

@cancerberoSgx would you be willing to submit your fix to that as a separate PR? Otherwise I will fix this soon as I can.

@dsherret
Copy link
Owner

dsherret commented Jul 6, 2018

Ok, this was too easy of a bug fix so I just fixed it now in 12.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants