Adding a type to an optional parameter marked by a question token puts the question token in the wrong spot

[gregjacobs]

Hey @dsherret. Looks like I found another interesting one. Trying to add a type to an optional parameter marked by a question token seems to put the '?' token in the wrong place in the output code. Check out this reproduction:

import Project, { MethodDeclaration, SyntaxKind } from 'ts-simple-ast';

const project = new Project();
const sourceFile = project.createSourceFile( 'my-file.ts', `
	class MyClass {
		someMethod( param1? ) {}
	}
` );


const method = sourceFile
	.getDescendantsOfKind( SyntaxKind.MethodDeclaration )[ 0 ] as MethodDeclaration;

const param1 = method.getParameters()[ 0 ];
param1.setType( 'any' );

console.log( 'Transformed:' );
console.log( sourceFile.getFullText() );

Basically the original source code:

class MyClass {
    someMethod( param1? ) {}
}

Gets changed into:

class MyClass {
    someMethod( param1: any? ) {}
}

Where the correct output should be:

class MyClass {
    someMethod( param1?: any ) {}
}

Best,
Greg

[dsherret]

As always, thanks for the excellent report @gregjacobs! Luckily for you I happened to be programming tonight so this is fixed now in 12.7.1.

[gregjacobs]

@dsherret You're the man! Thanks so much for the fix, and so quickly! Much appreciated!

Best,
Greg